[PATCH] D133849: [NFC] Pre commit test of PR57502

[Mingming Liu via Phabricator via llvm-commits]

mingmingl added inline comments.


================
Comment at: llvm/test/CodeGen/AArch64/pr57502.ll:2
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+; RUN: llc -mtriple=aarch64 -o - %s | FileCheck %s
+
----------------
It'd be good to add a line for big-endian systems (like 

`; RUN: llc < %s -mtriple aarch64_be-none-linux-gnu | FileCheck --check-prefix=CHECK-BE %s`)


================
Comment at: llvm/test/CodeGen/AArch64/pr57502.ll:18
+  %res = call i8 @llvm.vector.reduce.add.v4i8(<4 x i8> %var)
+  store i8 %res, ptr %addr
+  ret void
----------------
nit: return i8 directly (not using store) serves the purpose of preventing DCE.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133849/new/

https://reviews.llvm.org/D133849