[PATCH] D134072: [Support] Provide access to the full mapping in llvm::Annotations

Dmitri Gribenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 15:07:39 PDT 2022


gribozavr2 added inline comments.


================
Comment at: llvm/include/llvm/Testing/Support/Annotations.h:77
+  /// position. Unnamed points are mapped to the empty string. Order of points
+  /// for each name matches the order within the text.
+  const llvm::StringMap<llvm::SmallVector<size_t, 1>> &all_points() const;
----------------
"The positions are sorted." ?


================
Comment at: llvm/include/llvm/Testing/Support/Annotations.h:88
+  /// location. Unnamed ranges are mapped to the empty string. Order of ranges
+  /// for each name matches the order of start positions within the text.
+  const llvm::StringMap<llvm::SmallVector<Range, 1>> &all_ranges() const;
----------------
"The ranges are sorted by their start position." ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134072/new/

https://reviews.llvm.org/D134072



More information about the llvm-commits mailing list