[PATCH] D134072: [Support] Provide access to the full mapping in llvm::Annotations

Eric Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 12:40:46 PDT 2022


li.zhe.hua added inline comments.


================
Comment at: llvm/unittests/Support/AnnotationsTest.cpp:92
+      UnorderedElementsAre(
+          pair("", ElementsAre(range(0, 0), range(3, 4), range(3, 4))),
+          pair("outer", ElementsAre(range(2, 7), range(8, 10))),
----------------
ymandel wrote:
> why `ElementsAre` vs `UnorderedElementsAre`?
I've added a sentence to the documentation, clarifying the ordering.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134072/new/

https://reviews.llvm.org/D134072



More information about the llvm-commits mailing list