[PATCH] D134223: Analysis: Add AssumptionCache to isSafeToSpeculativelyExecute

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 14:15:17 PDT 2022


arsenm added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:1541
+      if (!isSafeToSpeculativelyExecute(Load, PL.first->getTerminator(),
+                                        nullptr, DT))
         return false;
----------------
jdoerfert wrote:
> Might be worth to do `/* AC */ nullptr` but we don't do that consistently unfortunately. 
I'm queuing up patches to pass it through everywhere, so it won't stay like this long


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134223/new/

https://reviews.llvm.org/D134223



More information about the llvm-commits mailing list