[PATCH] D134223: Analysis: Add AssumptionCache to isSafeToSpeculativelyExecute

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 19 14:14:30 PDT 2022


jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

One nit to consider. LG



================
Comment at: llvm/lib/Transforms/Scalar/GVN.cpp:1541
+      if (!isSafeToSpeculativelyExecute(Load, PL.first->getTerminator(),
+                                        nullptr, DT))
         return false;
----------------
Might be worth to do `/* AC */ nullptr` but we don't do that consistently unfortunately. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134223/new/

https://reviews.llvm.org/D134223



More information about the llvm-commits mailing list