[PATCH] D134098: [BOLT] Add pass to fix ambiguous memory references

Thorsten via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Sep 18 05:43:30 PDT 2022


tschuett added inline comments.


================
Comment at: bolt/include/bolt/Passes/ValidateMemRefs.h:15
+namespace llvm {
+namespace bolt {
+
----------------
You may use nested namespaces.


================
Comment at: bolt/lib/Passes/ValidateMemRefs.cpp:68
+        uint64_t Offset;
+        std::tie(Sym, Offset) = MIB->getTargetSymbolInfo(Operand.getExpr());
+        if (!Sym)
----------------
You may use structured bindings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134098/new/

https://reviews.llvm.org/D134098



More information about the llvm-commits mailing list