[PATCH] D134098: [BOLT] Add pass to fix ambiguous memory references

[Vladislav Khmelevsky via Phabricator via llvm-commits]

yota9 added inline comments.


================
Comment at: bolt/lib/Passes/ValidateMemRefs.cpp:22
+
+bool ValidateMemRefs::checkAndFixJTReference(BinaryContext &BC,
+                                             BinaryFunction &BF, MCInst &Inst,
----------------
BC might be taken from BF


================
Comment at: bolt/lib/Passes/ValidateMemRefs.cpp:87
+  LLVM_DEBUG(dbgs() << "BOLT-DEBUG: Starting memrefs validation pass\n");
+  for (auto &BFI : BC.getBinaryFunctions()) {
+    BinaryFunction &Function = BFI.second;
----------------
Just curious why not to parallel this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134098/new/

https://reviews.llvm.org/D134098