[PATCH] D134058: [lld-macho] Support -dyld_env

Sat Sep 17 22:57:49 PDT 2022

thevinster added inline comments.

================
Comment at: lld/MachO/Driver.cpp:1417
+    // Validate that the argument is in the form
+    // DYLD_<something>_PATH=<some_value>.
+    StringRef dyldEnv = saver().save(arg->getValue());
----------------
Should `something` be validated here? Is it limited to a list of known possible values that could be enumerated or is it valid to have `DYLD_FOO_PATH=foo` embedded in the binary? 

================
Comment at: lld/test/MachO/dyld-env.s:1
+# REQUIRES: x86, shell
+
----------------
thakis wrote:
> why does this need shell?
I believe shell is needed to run the symlinks. Alternatively, we could make this test not be supported on windows. 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134058/new/

https://reviews.llvm.org/D134058