[PATCH] D134097: [NFC] Refactor creation of symbol+addend references

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 17 11:17:47 PDT 2022


yota9 accepted this revision.
yota9 added a comment.
This revision is now accepted and ready to land.

Thanks for the refactoring!



================
Comment at: bolt/lib/Core/BinaryFunction.cpp:1054
+  (void)ReplaceSuccess;
+  assert(ReplaceSuccess && "failed to replace mem operand with symbol+off");
 }
----------------
Maybe change assert to if + exit ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D134097/new/

https://reviews.llvm.org/D134097



More information about the llvm-commits mailing list