[PATCH] D134098: [BOLT] Add pass to fix ambiguous memory references

Rafael Auler via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 16 18:36:28 PDT 2022


rafauler created this revision.
rafauler added a reviewer: bolt.
Herald added subscribers: treapster, ayermolo, mgorny.
Herald added a reviewer: Amir.
Herald added a reviewer: maksfb.
Herald added a project: All.
rafauler requested review of this revision.
Herald added subscribers: llvm-commits, yota9.
Herald added a project: LLVM.

This adds a round of checks to memory references, looking for
incorrect references to jump table objects. Fix them by replacing the
jump table reference with another object reference + offset.

This solves bugs related to regular data references in code
accidentally being bound to a jump table, and this reference being
updated to a new (incorrect) location because we moved this jump
table.

Fixes #55004


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134098

Files:
  bolt/include/bolt/Passes/ValidateMemRefs.h
  bolt/lib/Core/BinaryEmitter.cpp
  bolt/lib/Passes/CMakeLists.txt
  bolt/lib/Passes/ValidateMemRefs.cpp
  bolt/lib/Rewrite/BinaryPassManager.cpp
  bolt/test/runtime/X86/jt-symbol-disambiguation-2.s
  bolt/test/runtime/X86/jt-symbol-disambiguation.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134098.460955.patch
Type: text/x-patch
Size: 12595 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220917/c3641f40/attachment.bin>


More information about the llvm-commits mailing list