[PATCH] D133914: [InlineAsm][bugfix] Correct function addressing in inline asm

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:8814
+      if (TM.getCodeModel() != CodeModel::Large)
+        OpInfo.ConstraintType = TargetLowering::C_Address;
+    }
----------------
What's the difference between C_Address and C_Memory?


================
Comment at: llvm/test/CodeGen/X86/inline-asm-function-call-pic.ll:71
+
+attributes #0 = { nounwind uwtable "frame-pointer"="none" "min-legal-vector-width"="0" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="pentium4" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" }
+attributes #1 = { "frame-pointer"="none" "no-trapping-math"="true" "stack-protector-buffer-size"="8" "target-cpu"="pentium4" "target-features"="+cx8,+fxsr,+mmx,+sse,+sse2,+x87" "tune-cpu"="generic" }
----------------
Do we need these attribute for the test case?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133914/new/

https://reviews.llvm.org/D133914