[PATCH] D133914: [InlineAsm][bugfix] Correct function addressing in inline asm

[LuoYuanke via Phabricator via llvm-commits]

LuoYuanke added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetSubtargetInfo.h:315
+  virtual unsigned char
+  classifyGlobalFunctionReference(const GlobalValue *GV) const {
+    return 0;
----------------
RKSimon wrote:
> Add a description comment
It seems each target has it's own defintion for the return value. Is it interpreted by target when it is used?


================
Comment at: llvm/test/CodeGen/X86/inline-asm-function-call-pic.ll:12
+; 8 }
+; 9
+;10 void func() {
----------------
Remove the original line number of the source code?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133914/new/

https://reviews.llvm.org/D133914