[PATCH] D134080: [Inliner] Retire DefaultInlineOrder (NFC)

[Kazu Hirata via Phabricator via llvm-commits]

kazu created this revision.
Herald added subscribers: ormris, hiraditya.
Herald added a project: All.
kazu requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

DefaultInlineOrder was largely an exercise in generalizing the
traversal order of call sites within the inliner.

Now that the module inliner is starting to form its shape, there is no
point in sharing DefaultInlineOrder between the module inliner and the
CGSCC inliner.  DefaultInlineOrder and all the other inline orders are
mutually exclusive in the following sense:

- The use of DefaultInlineOrder doesn't make sense in the module inliner because there is no priority inherent in the order in which call sites are added to the list of call sites -- SmallVector.

- The use of any other inline order doesn't make sense in the CGSCC inliner because little prioritization can be done within one CGSCC.

This patch essentially reverts the addition of DefaultInlineOrder so
that the loop structure of Inliner.cpp looks like the state just
before we started working on the module inliner (circa June 2021).

At the same time, ww remove the choice of DefaultInlineOrder from
UseInlinePriority.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D134080

Files:
  llvm/include/llvm/Analysis/InlineOrder.h
  llvm/lib/Analysis/InlineOrder.cpp
  llvm/lib/Transforms/IPO/Inliner.cpp
  llvm/lib/Transforms/IPO/ModuleInliner.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D134080.460903.patch
Type: text/x-patch
Size: 7412 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220916/f14add5e/attachment.bin>