[PATCH] D131276: AMDGPU: Implicit kernel arguments related optimization when uniform-workgroup-size=true

[Matt Arsenault via Phabricator via llvm-commits]

arsenm requested changes to this revision.
arsenm added a comment.
This revision now requires changes to proceed.

This should really merge the processUse logic together



================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerKernelAttributes.cpp:79
 
+static bool processImplicitArgUse(CallInst *CI) {
+  Function *F = CI->getParent()->getParent();
----------------
cfang wrote:
> arsenm wrote:
> > You've repeated most of the body of the existing function when only the core piece of the match differs.
> Actually that is not pure repeat even though the logic is the same. The fields, offsets and even the base pointers are different. 
The entire core logic is the same. You can select between the pointers, fields and offsets within the same function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131276/new/

https://reviews.llvm.org/D131276