[PATCH] D133928: [AMDGPU] Add GFX11 ds_bvh_stack_rtn_b32 instruction

[Jay Foad via Phabricator via llvm-commits]

foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/DSInstructions.td:289
+  let gdsValue = 0;
+  let hasSideEffects = 1;
+  let SchedRW = [WriteLDS, WriteLDS];
----------------
arsenm wrote:
> Does this really have side effects?
It reads and writes LDS in a complicated way. Previously we've used hasSideEffects=1 to model complicated GDS access, e.g. on the DS_ADD/SUB_GS_REG_RTN instructions. Is there a better way? Should we be using MMOs with addrspace 2/3 but no pointer info instead? If so I'd prefer to do that as a follow up.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133928/new/

https://reviews.llvm.org/D133928