[PATCH] D133928: [AMDGPU] Add GFX11 ds_bvh_stack_rtn_b32 instruction

Thu Sep 15 06:57:14 PDT 2022

arsenm accepted this revision.
arsenm added a comment.
This revision is now accepted and ready to land.

In D133928#3792248 <https://reviews.llvm.org/D133928#3792248>, @foad wrote:

> In D133928#3792158 <https://reviews.llvm.org/D133928#3792158>, @arsenm wrote:
>
>> I don't see why this needs manual selection
>
> The comments say "tablegen doesn't support matching instructions with multiple outputs". Is that not true? (I'm not the original author of this patch.)

I missed the second return value somehow

================
Comment at: llvm/lib/Target/AMDGPU/DSInstructions.td:289
+  let gdsValue = 0;
+  let hasSideEffects = 1;
+  let SchedRW = [WriteLDS, WriteLDS];
----------------
Does this really have side effects?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133928/new/

https://reviews.llvm.org/D133928