[PATCH] D132942: [PowerPC][GISel]add support for float point arithmetic operations
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Sep 15 06:54:43 PDT 2022
arsenm added inline comments.
================
Comment at: llvm/lib/Target/PowerPC/GISel/PPCInstructionSelector.cpp:100-114
+ const TargetRegisterClass *RC =
+ getRegClass(MRI.getType(DstReg), RBI.getRegBank(DstReg, MRI, TRI));
+ if (!RBI.constrainGenericRegister(DstReg, *RC, MRI)) {
+ LLVM_DEBUG(dbgs() << "Failed to constrain " << TII.getName(I.getOpcode())
+ << " dest operand\n");
return false;
+ }
----------------
This won't correctly handle the case where the incoming copy already has a class assigned. This may end up widening the class constraint
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132942/new/
https://reviews.llvm.org/D132942
More information about the llvm-commits
mailing list