[PATCH] D133869: [RISCV] Verify SEW/VecPolicy immediate values
Alex Bradbury via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 14 12:31:08 PDT 2022
asb added a comment.
@reames what's your thinking about the current asserts in the printing code - to keep them, or not?
I think it definitely makes sense to add these verifier rules and the code seems like an accurate translation from the printing code to my eyes. I'd appreciate if someone else a little more familiar with the vector instructions would give a quick additional review, but otherwise LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133869/new/
https://reviews.llvm.org/D133869
More information about the llvm-commits
mailing list