[PATCH] D133864: [AMDGPU][MC][GFX11] Add VOPD literals validation

Dmitry Preobrazhensky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 10:49:03 PDT 2022


dp added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4356
   if (NumLiterals > 1) {
-    Error(getLitLoc(Operands), "only one literal operand is allowed");
+    Error(getLitLoc(Operands, true), "only one literal operand is allowed");
     return false;
----------------
Joe_Nash wrote:
> It seems helpful to say "only one **unique** literal operand is allowed".
> It seems helpful to say "only one **unique** literal operand is allowed".

Thanks! I'll correct wording in a separate commit because the change will affect many existing tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133864/new/

https://reviews.llvm.org/D133864



More information about the llvm-commits mailing list