[PATCH] D133864: [AMDGPU][MC][GFX11] Add VOPD literals validation
Joe Nash via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Sep 14 10:09:28 PDT 2022
Joe_Nash accepted this revision.
Joe_Nash added a comment.
This revision is now accepted and ready to land.
Thanks for the test changes. See my comment about adding unique to error message, otherwise LGTM.
================
Comment at: llvm/lib/Target/AMDGPU/AsmParser/AMDGPUAsmParser.cpp:4356
if (NumLiterals > 1) {
- Error(getLitLoc(Operands), "only one literal operand is allowed");
+ Error(getLitLoc(Operands, true), "only one literal operand is allowed");
return false;
----------------
It seems helpful to say "only one **unique** literal operand is allowed".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133864/new/
https://reviews.llvm.org/D133864
More information about the llvm-commits
mailing list