[PATCH] D133787: [AMDGPU][SILoadStoreOptimizer] Merge SGPR_IMM scalar buffer loads.

[Ivan Kosarev via Phabricator via llvm-commits]

kosarev marked 2 inline comments as done.
kosarev added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SILoadStoreOptimizer.cpp:640
     return Result;
+  case AMDGPU::S_BUFFER_LOAD_DWORD_SGPR_IMM:
+  case AMDGPU::S_BUFFER_LOAD_DWORDX2_SGPR_IMM:
----------------
foad wrote:
> Don't you need to list the _SGPR forms here too?
Oh, that's a nice catch, thanks. I've updated `hasSameBaseAddress()` above to compare the number of address operands so tests could catch this as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133787/new/

https://reviews.llvm.org/D133787