[PATCH] D133854: [lld-macho] Fix -force_symbols_{, not_}weak_list arg type

Bernhard Urban-Forster via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Sep 14 05:25:39 PDT 2022


lewurm created this revision.
lewurm added reviewers: int3, lld-macho.
lewurm added a project: lld-macho.
Herald added a reviewer: ributzka.
Herald added a project: All.
lewurm requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

This is still undocumented and unsupported, but if someone passed it before you would end up with a missing file error since this takes an argument that wouldn't be handled.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D133854

Files:
  lld/MachO/Options.td


Index: lld/MachO/Options.td
===================================================================
--- lld/MachO/Options.td
+++ lld/MachO/Options.td
@@ -1246,11 +1246,11 @@
     HelpText<"This option is undocumented in ld64">,
     Flags<[HelpHidden]>,
     Group<grp_undocumented>;
-def force_symbols_not_weak_list : Flag<["-"], "force_symbols_not_weak_list">,
+def force_symbols_not_weak_list : Separate<["-"], "force_symbols_not_weak_list">,
     HelpText<"This option is undocumented in ld64">,
     Flags<[HelpHidden]>,
     Group<grp_undocumented>;
-def force_symbols_weak_list : Flag<["-"], "force_symbols_weak_list">,
+def force_symbols_weak_list : Separate<["-"], "force_symbols_weak_list">,
     HelpText<"This option is undocumented in ld64">,
     Flags<[HelpHidden]>,
     Group<grp_undocumented>;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133854.460046.patch
Type: text/x-patch
Size: 808 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220914/87be0241/attachment.bin>


More information about the llvm-commits mailing list