[PATCH] D133593: [AMDGPU] Always select s_cselect_b32 for uniform 'select' SDNode

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:4002
 
+  /// @brief Allows the target to handle physreg-carried dependency
+  /// in target-specific way. Used from the ScheduleDAGSDNodes to decide whether
----------------
Could you please use the same comment style as the rest of the code?


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12998
+  const MCInstrDesc &II = TII->get(MDef->getMachineOpcode());
+  if (II.isCompare() && II.hasImplicitDefOfPhysReg(AMDGPU::SCC)) {
+    PhysReg = AMDGPU::SCC;
----------------
alex-t wrote:
> rampitec wrote:
> > We may actually later extend it beyond compares and to include VCC.
> What needs to be changed here right now for that?
Nothing right now.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133593/new/

https://reviews.llvm.org/D133593