[PATCH] D133593: [AMDGPU] Always select s_cselect_b32 for uniform 'select' SDNode

Alexander via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 08:54:05 PDT 2022


alex-t added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12998
+  const MCInstrDesc &II = TII->get(MDef->getMachineOpcode());
+  if (II.isCompare() && II.hasImplicitDefOfPhysReg(AMDGPU::SCC)) {
+    PhysReg = AMDGPU::SCC;
----------------
rampitec wrote:
> We may actually later extend it beyond compares and to include VCC.
What needs to be changed here right now for that?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133593/new/

https://reviews.llvm.org/D133593



More information about the llvm-commits mailing list