[PATCH] D133747: Address feedback in https://reviews.llvm.org/D133637

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 13 13:14:07 PDT 2022


MatzeB accepted this revision.
MatzeB added a comment.
This revision is now accepted and ready to land.

LGTM, thanks



================
Comment at: llvm/lib/CodeGen/MachineOperand.cpp:329
+      const TargetRegisterInfo *TRI = MF->getSubtarget().getRegisterInfo();
+      unsigned RegMaskSize = (TRI->getNumRegs() + 31) / 32;
       // Deep compare of the two RegMasks
----------------



================
Comment at: llvm/lib/CodeGen/MachineOperand.cpp:387-388
+    if (const MachineFunction *MF = getMFIfAvailable(MO)) {
+      const TargetRegisterInfo *TRI = MF->getSubtarget().getRegisterInfo();
+      unsigned RegMaskSize = (TRI->getNumRegs() + 31) / 32;
+      const uint32_t *RegMask = MO.getRegMask();
----------------



================
Comment at: llvm/lib/CodeGen/MachineStableHash.cpp:127
+          const TargetRegisterInfo *TRI = MF->getSubtarget().getRegisterInfo();
+          unsigned RegMaskSize = (TRI->getNumRegs() + 31) / 32;
+          const uint32_t *RegMask = MO.getRegMask();
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133747/new/

https://reviews.llvm.org/D133747



More information about the llvm-commits mailing list