[PATCH] D133747: Address feedback in https://reviews.llvm.org/D133637

[Ellis Hoag via Phabricator via llvm-commits]

ellis added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineOperand.cpp:396
+
+    assert(0 && "MachineOperand not associated with any MachineFunction");
+    return hash_combine(MO.getType(), MO.getTargetFlags());
----------------
I find it a bit strange that we are failing an assert but still returning something. Is this better suited for `llvm_unreachable()`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133747/new/

https://reviews.llvm.org/D133747