[PATCH] D133646: Add a utility for converting between different types of remarks
Jessica Paquette via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Sep 12 15:03:20 PDT 2022
paquette updated this revision to Diff 459567.
paquette added a comment.
Add missing `std::move` when returning an `Error`. That was the only issue that showed up when I built the patch inside a Debian Docker container.
It looks like the tests fail cause applying the patch won't actually create the correct binary files. Going to push now.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D133646/new/
https://reviews.llvm.org/D133646
Files:
llvm/docs/CommandGuide/LLVMRemarkUtil.rst
llvm/docs/CommandGuide/index.rst
llvm/test/CMakeLists.txt
llvm/test/lit.cfg.py
llvm/test/tools/llvm-remarkutil/Inputs/broken-remark
llvm/test/tools/llvm-remarkutil/Inputs/broken-remark.bitstream
llvm/test/tools/llvm-remarkutil/Inputs/empty-file
llvm/test/tools/llvm-remarkutil/Inputs/two-remarks.bitstream
llvm/test/tools/llvm-remarkutil/Inputs/two-remarks.yaml
llvm/test/tools/llvm-remarkutil/broken-bitstream-remark.test
llvm/test/tools/llvm-remarkutil/broken-yaml-remark.test
llvm/test/tools/llvm-remarkutil/convert.test
llvm/test/tools/llvm-remarkutil/empty-file.test
llvm/test/tools/llvm-remarkutil/file-does-not-exist.test
llvm/test/tools/llvm-remarkutil/missing-subcommand.test
llvm/tools/llvm-remarkutil/CMakeLists.txt
llvm/tools/llvm-remarkutil/RemarkUtil.cpp
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133646.459567.patch
Type: text/x-patch
Size: 15794 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220912/7be44b15/attachment.bin>
More information about the llvm-commits
mailing list