[PATCH] D133646: Add a utility for converting between different types of remarks

[Jessica Paquette via Phabricator via llvm-commits]

paquette updated this revision to Diff 459524.
paquette added a comment.

Francis pointed out to me that the Darwin assumption for bitstream only holds when embedding metadata in `Separate` mode.

- Drop the Darwin check
- Try to modify the test to see if we can make Debian and Windows happy in the pre-merge checks.

Current assumption is that piping binary data is weird in the tests, although it Works On My Machine™


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133646/new/

https://reviews.llvm.org/D133646

Files:
  llvm/docs/CommandGuide/LLVMRemarkUtil.rst
  llvm/docs/CommandGuide/index.rst
  llvm/test/CMakeLists.txt
  llvm/test/lit.cfg.py
  llvm/test/tools/llvm-remarkutil/Inputs/broken-remark
  llvm/test/tools/llvm-remarkutil/Inputs/broken-remark.bitstream
  llvm/test/tools/llvm-remarkutil/Inputs/empty-file
  llvm/test/tools/llvm-remarkutil/Inputs/two-remarks.bitstream
  llvm/test/tools/llvm-remarkutil/Inputs/two-remarks.yaml
  llvm/test/tools/llvm-remarkutil/broken-bitstream-remark.test
  llvm/test/tools/llvm-remarkutil/broken-yaml-remark.test
  llvm/test/tools/llvm-remarkutil/convert.test
  llvm/test/tools/llvm-remarkutil/empty-file.test
  llvm/test/tools/llvm-remarkutil/file-does-not-exist.test
  llvm/test/tools/llvm-remarkutil/missing-subcommand.test
  llvm/tools/llvm-remarkutil/CMakeLists.txt
  llvm/tools/llvm-remarkutil/RemarkUtil.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D133646.459524.patch
Type: text/x-patch
Size: 15783 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220912/972cf939/attachment.bin>