[PATCH] D133690: [VP][RISCV] Add vp.fsqrt intrinsic and RISC-V support.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/docs/LangRef.rst:19219
+
+The '``llvm.vp.sqrt``' intrinsic performs floating-point absolute value
+(:ref:`sqrt <int_sqrt>`) of the first vector operand on each enabled lane.  The
----------------
This does not perform "floating-point absolute value":


================
Comment at: llvm/docs/LangRef.rst:19221
+(:ref:`sqrt <int_sqrt>`) of the first vector operand on each enabled lane.  The
+result on disabled lanes is undefined.
+
----------------
reames wrote:
> Can you be more explicit here about the result being undefined, not the behavior?  i.e. that masked off lanes won't fault, etc..
I would prefer that be done globally to all of the descriptions in a separate patch since this currently consistent with other operations.

It does need "The operation is performed in the default floating-point environment." to match other arithmetic instructions though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133690/new/

https://reviews.llvm.org/D133690