[PATCH] D132799: Make sure libLLVM users link with libatomic if needed

[Aaron Puchert via Phabricator via llvm-commits]

aaronpuchert added a comment.

In D132799#3783603 <https://reviews.llvm.org/D132799#3783603>, @mstorsjo wrote:

> CMake manages to find a custom-installed libzstd in a nondefault location (`/home/linuxbrew/.linuxbrew/lib/libzstd.so.1.5.2`), and for every other place that these dependencies are used, it's linked by just adding that absolute path to the linking command line. However after this commit, when linking, it links by passing both `-lzstd` and `/home/linuxbrew/.linuxbrew/lib/libzstd.so.1.5.2`, and linking fails since the `-lzstd` is unresolved.

My understanding is that `` is also used as output of `llvm-config --system-libs`. Should this also print the full path? Perhaps you can check what it currently prints? Or have a look in the build directory at `tools/llvm-config/BuildVariables.inc`.

We likely get `zstd` in `LLVM_SYSTEM_LIBS` because `lib/Support/CMakeLists.txt` goes to some lengths to strip the path. But I'm not sure why.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132799/new/

https://reviews.llvm.org/D132799