[PATCH] D132799: Make sure libLLVM users link with libatomic if needed

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 12 06:03:10 PDT 2022


mstorsjo added a comment.

This caused an unexpected issue in builds with dylibs enabled for me - see https://github.com/mstorsjo/llvm-mingw/runs/8296785193?check_suite_focus=true#logs.

CMake manages to find a custom-installed libzstd in a nondefault location (`/home/linuxbrew/.linuxbrew/lib/libzstd.so.1.5.2`), and for every other place that these dependencies are used, it's linked by just adding that absolute path to the linking command line. However after this commit, when linking, it links by passing both `-lzstd` and `/home/linuxbrew/.linuxbrew/lib/libzstd.so.1.5.2`, and linking fails since the `-lzstd` is unresolved.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132799/new/

https://reviews.llvm.org/D132799



More information about the llvm-commits mailing list