[PATCH] D129868: [SystemZInstPrinter] Introduce markup tags emission

Antonio Frighetto via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Sep 10 02:05:31 PDT 2022


antoniofrighetto added a comment.

@uweigand, we leverage LLVM disassembler (and, specifically, `MCInstPrinter::printInst`) as part of our static binary translator tool, here <https://github.com/revng/revng/blob/develop/lib/Yield/Assembly/LLVMDisassemblerInterface.cpp#L301>, though I assume I could count many other uses that I'm not aware of (we've updated other targets too in order to support markup).

I'm actually using `UseMarkup` member field anywhere, except for the static functions – whose callers are `PrintAsmOperand` / `PrintMemAsmOperand`, as you noted – for which, clearly, I could not. I reckon it's not really that big of a deal, being limited to a very small portion of the code.

Test fixed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129868/new/

https://reviews.llvm.org/D129868



More information about the llvm-commits mailing list