[PATCH] D133253: [SPIRV] add IR regularization passes

[Aleksandr Bezzubikov via Phabricator via llvm-commits]

zuban32 requested changes to this revision.
zuban32 added a comment.
This revision now requires changes to proceed.

Could you pls specify a list of these small bug fixes, at the very high level at least? An ideal variant would be to not mix them up with this regularization stuff at all.



================
Comment at: llvm/lib/Target/SPIRV/SPIRVCallLowering.cpp:118
 
+static MDString *getKernelArgAttribute(const Function &KernelFunction,
+                                       unsigned ArgIdx,
----------------
Alright, this doesn't look like a small change to me. Can this be moved into a separate patch, current description doesn't say anything specific about this anyway?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133253/new/

https://reviews.llvm.org/D133253