[PATCH] D130479: [ORC_RT][COFF] Initial platform support for COFF/x86_64.

[Sunho Kim via Phabricator via llvm-commits]

sunho added a comment.

In D130479#3776221 <https://reviews.llvm.org/D130479#3776221>, @yingcong-wu wrote:

> check-all failed with those tests:
>
>   ORC-x86_64-windows :: TestCases/Windows/x86-64/hello-world.c
>   ORC-x86_64-windows :: TestCases/Windows/x86-64/hello-world.cpp
>   ORC-x86_64-windows :: TestCases/Windows/x86-64/priority-static-initializer-three.c
>   ORC-x86_64-windows :: TestCases/Windows/x86-64/priority-static-initializer.c
>   ORC-x86_64-windows :: TestCases/Windows/x86-64/sehframe-handling.cpp
>   ORC-x86_64-windows :: TestCases/Windows/x86-64/static-initializer.S
>   ORC-x86_64-windows :: TestCases/Windows/x86-64/static-initializer.cpp
>
> Directly caused by incorrect orc runtime library filename in Windows.
>
> But after changing the filename in `compiler-rt/test/orc/lit.cfg.py`, tests reported
>
>   llvm-jitlink error: Could not find symbol at given index, did you add it to JITSymbolTable? index: 441, section: 3001
>   D:\bin\llvm-jitlink.exe: Failed to materialize symbols: { (main, { __orc_rt_coff_symbol_lookup_tag }) }
>
> Build Info
>
> - Build type: Debug
> - Target: X86
> - In tree build
>
> Could you please give me some clues?

I believe it's related to build type -- we always try to load up release build of vc runtime libs which can fail in debug build of compiler-rt. I was aware of different library name, but I just wasn't sure exactly when different name happens. Could you share more details on your build setting and error log?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130479/new/

https://reviews.llvm.org/D130479