[PATCH] D130479: [ORC_RT][COFF] Initial platform support for COFF/x86_64.

[Wu Yingcong via Phabricator via llvm-commits]

yingcong-wu reopened this revision.
yingcong-wu added a comment.
This revision is now accepted and ready to land.

check-all failed with those tests:

  ORC-x86_64-windows :: TestCases/Windows/x86-64/hello-world.c
  ORC-x86_64-windows :: TestCases/Windows/x86-64/hello-world.cpp
  ORC-x86_64-windows :: TestCases/Windows/x86-64/priority-static-initializer-three.c
  ORC-x86_64-windows :: TestCases/Windows/x86-64/priority-static-initializer.c
  ORC-x86_64-windows :: TestCases/Windows/x86-64/sehframe-handling.cpp
  ORC-x86_64-windows :: TestCases/Windows/x86-64/static-initializer.S
  ORC-x86_64-windows :: TestCases/Windows/x86-64/static-initializer.cpp

Directly caused by incorrect orc runtime library filename in Windows.

But after changing the filename in `compiler-rt/test/orc/lit.cfg.py`, tests reported

  llvm-jitlink error: Could not find symbol at given index, did you add it to JITSymbolTable? index: 441, section: 3001
  D:\bin\llvm-jitlink.exe: Failed to materialize symbols: { (main, { __orc_rt_coff_symbol_lookup_tag }) }

Build Info

- Build type: Debug
- Target: X86
- In tree build

Could you please give me some clues?



================
Comment at: compiler-rt/test/orc/lit.cfg.py:17-20
 if config.host_os == 'Darwin':
   orc_rt_path = '%s/libclang_rt.orc_osx.a' % config.compiler_rt_libdir
 else:
   orc_rt_path = '%s/libclang_rt.orc%s.a' % (config.compiler_rt_libdir, config.target_suffix)
----------------
In my local build in X86 Windows, the orc runtime library filename is `clang_rt.orc-x86_64.lib`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130479/new/

https://reviews.llvm.org/D130479