[PATCH] D133456: [V2] MC: make section classification a bit more thorough

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Sep 9 06:54:04 PDT 2022


compnerd added inline comments.


================
Comment at: llvm/lib/MC/MCContext.cpp:592
+               .StartsWith(".debug_", SectionKind::getMetadata())
+               .Default(SectionKind::getText());
 
----------------
MaskRay wrote:
> Is default `SectionKind::getText()` instead of `SectionKind::getReadOnly()` desired? I expect that text is covered by a previous `if`: `Flags & ELF::SHF_EXECINSTR`
This is the core of the change itself - and what is needed for subsequent changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133456/new/

https://reviews.llvm.org/D133456



More information about the llvm-commits mailing list