[PATCH] D132146: [PowerPC] XCOFF exception section support on assembler path and exception language and reason code lowering from trap intrinsics

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:4566
+  virtual void LowerTargetIntrinsic(const CallInst &I, SDValue &Op,
+                                    SmallVector<SDValue, 8> &Ops,
+                                    SelectionDAG &DAG) const;
----------------
Please document the instruction and its arguments. Is Op necessary - should it be returned instead? Use SmallVectorImpl<SDValue>?


================
Comment at: llvm/include/llvm/MC/MCStreamer.h:639
+                                        const unsigned Lang, 
+                                        const unsigned Reason);
+
----------------
is it really necessary to add const to the integer args?


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4838
   SDValue Result;
+  TLI.LowerTargetIntrinsic(I, Result, Ops, DAG);
   if (IsTgtIntrinsic) {
----------------
Do you need Result? Should this be returning anything?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132146/new/

https://reviews.llvm.org/D132146