[PATCH] D132441: Fix FindZ3.cmake's version detection mechanism

[Zhang via Phabricator via llvm-commits]

Naville added a comment.

In D132441#3779344 <https://reviews.llvm.org/D132441#3779344>, @Godin wrote:

> Hi @Naville ,
>
> Please excuse for the delay with the response, I think @steakhal wanted to see the response from me, but it was a day off for me yesterday.
>
>> The linked test program failed to execute because it's missing a specific version of CRT (I remember it was Debug version of CRT vs. Release version of CRT)
>
> Isn't it the root of the problem that should be fixed instead? To my taste, it sounds a bit weird for the non-cross-compiling mode to let the build process continue after the failure to run the test program due to such a mismatch - isn't this opening a door for a failure to link Z3 with Clang later?
> I'm also not on Windows, but we have a CI at work that builds Clang with Z3, and I saw such a mismatch only in cases when z3 will fail to link with Clang, so I'm curious if can reproduce your case in order to better understand it - could you please share how do you build Z3 and Clang?

Hi:
I think Z3 was built with VCPKG with triplet ``x64-windows``, unfortunately can't reproduce the exact environment since it's been a while and we have switch to static built z3 since.
But I do remember at one time I need to add ``%Path%=.....`` to add Z3.dll and its dependencies to the DLL search path for the test program to work, even without CRT version mismatch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132441/new/

https://reviews.llvm.org/D132441