[PATCH] D132441: Fix FindZ3.cmake's version detection mechanism

[Evgeny Mandrikov via Phabricator via llvm-commits]

Godin added a comment.

Hi @Naville ,

Please excuse for the delay with the response, I think @steakhal wanted to see the response from me, but it was a day off for me yesterday.

> The linked test program failed to execute because it's missing a specific version of CRT (I remember it was Debug version of CRT vs. Release version of CRT)

Isn't it the root of the problem that should be fixed instead? To my taste, it sounds a bit weird for the non-cross-compiling mode to let the build process continue after the failure to run the test program due to such a mismatch - isn't this opening a door for a failure to link Z3 with Clang later?
I'm also not on Windows, but we have a CI at work that builds Clang with Z3, and I saw such a mismatch only in cases when z3 will fail to link with Clang, so I'm curious if can reproduce your case in order to better understand it - could you please share how do you build Z3 and Clang?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132441/new/

https://reviews.llvm.org/D132441