[PATCH] D131786: [ARM] Support all versions of AND, ORR, EOR and BIC in optimizeCompareInstr

[Dave Green via Phabricator via llvm-commits]

dmgreen added reviewers: efriedma, samtebbs.
dmgreen added a comment.

Sounds like a good patch. Are all the cases covered by the tests? It looks like they are, but it's a bit hard to tell from the current file.



================
Comment at: llvm/test/CodeGen/ARM/cmp-peephole.ll:6
+
+define i1 @cmp_ne_zero_and_rr(i32 %a, i32 %b) {
+; ARM-LABEL: cmp_ne_zero_and_rr:
----------------
fzhinkin wrote:
> I'll precommit new tests if there will be no objections.
Precommitting the tests sounds good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131786/new/

https://reviews.llvm.org/D131786