[PATCH] D133379: [DL] Make vector ABI align bound by element align

Tex Riddell via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 16:36:06 PDT 2022


tex3d added a comment.

I don't see why we would want a different behavior here between ABI and preferred alignments.



================
Comment at: llvm/lib/IR/DataLayout.cpp:808
+      if (!abi_or_pref)
+        return I->PrefAlign;
+
----------------
Shouldn't this capture the preferred alignment value for use in the maxAlignment, or return if not vector?  Or is this mechanism intended to only apply to ABI alignment and not preferred alignment?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133379/new/

https://reviews.llvm.org/D133379



More information about the llvm-commits mailing list