[PATCH] D133379: [DL] Make vector ABI align bound by element align

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 15:13:30 PDT 2022


efriedma added a comment.

Whatever we do here should be documented in LangRef.

I'm a little wary of making assumptions like this implicitly. I think I'd prefer to make the datalayout string explicitly request this behavior.



================
Comment at: llvm/include/llvm/Support/Alignment.h:218
 
+/// Return the more larger of the two alignments.
+inline Align maxAlignment(Align LHS, Align RHS) {
----------------
Can you not just use std::max?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133379/new/

https://reviews.llvm.org/D133379



More information about the llvm-commits mailing list