[PATCH] D132441: Fix FindZ3.cmake's version detection mechanism

Zhang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 12:12:18 PDT 2022


Naville added a comment.

In D132441#3772196 <https://reviews.llvm.org/D132441#3772196>, @steakhal wrote:

> Oh, @Godin called my attention to a detail. Now, I'm no longer comfortable approving this unless I get some clarification.

Hi:

In the Windows example (similar reasoning elsewhere):

- The linked test program failed to execute because it's missing a specific version of CRT (I remember it was Debug version of CRT vs. Release version of CRT)
- In this case the program still failed to execute, but it's definitely not cross-compiling since we are still targeting x64 Windows




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132441/new/

https://reviews.llvm.org/D132441



More information about the llvm-commits mailing list