[PATCH] D132441: Fix FindZ3.cmake's version detection mechanism

[Balázs Benics via Phabricator via llvm-commits]

steakhal requested changes to this revision.
steakhal added a comment.
This revision now requires changes to proceed.

Oh, @Godin called my attention to a detail. Now, I'm no longer comfortable approving this unless I get some clarification.



================
Comment at: llvm/cmake/modules/FindZ3.cmake:85
 # check the version in the headers, otherwise, fail with a message
-if(NOT Z3_VERSION_STRING AND (CMAKE_CROSSCOMPILING AND
-                              Z3_INCLUDE_DIR AND
-                              EXISTS "${Z3_INCLUDE_DIR}/z3_version.h"))
+if(NOT Z3_VERSION_STRING AND (Z3_INCLUDE_DIR AND EXISTS "${Z3_INCLUDE_DIR}/z3_version.h"))
   # TODO: print message warning that we couldn't find a compatible lib?
----------------
Why did you remove the `CMAKE_CROSSCOMPILING`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D132441/new/

https://reviews.llvm.org/D132441