[PATCH] D130506: [Support] Add llvm::compression::{getReasonIfUnsupported,compress,decompress}

[Cole Kissane via Phabricator via llvm-commits]

ckissane added inline comments.


================
Comment at: llvm/include/llvm/Support/Compression.h:26-27
+// object file formats (e.g. ELF). This is a separate class as we may add new
+// compression::Format members for non-debugging purposes.
+enum class DebugCompressionType {
+  None, ///< No compression
----------------
ckissane wrote:
> I think a renaming would be good to keep this extra clear.
> Not a blocker though
> it could also be good to keep this enum closer to elf-related code.
Note that you state:
> Move llvm::DebugCompressionType from MC to Support to avoid Support->MC cyclic
> dependency. There are 40+ uses in llvm-project.

would moving both this enum and
```
inline Format formatFor(DebugCompressionType Type) 
```
into MC also resolve this?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130506/new/

https://reviews.llvm.org/D130506