[PATCH] D130506: [Support] Add llvm::compression::{getReasonIfUnsupported,compress,decompress}

[Cole Kissane via Phabricator via llvm-commits]

ckissane accepted this revision.
ckissane added a comment.
This revision is now accepted and ready to land.

Looks like my concerns about the enum coupling and none vs unsupported semantics are addressed, one nit though.
LGTM, however, @dblaikie may want to take a pass as well. (Though I think this should be fine with him, because even if the final state of compression api in llvm is more OO, this regardless moves it closer in that direction than the original api.)



================
Comment at: llvm/include/llvm/Support/Compression.h:26-27
+// object file formats (e.g. ELF). This is a separate class as we may add new
+// compression::Format members for non-debugging purposes.
+enum class DebugCompressionType {
+  None, ///< No compression
----------------
I think a renaming would be good to keep this extra clear.
Not a blocker though
it could also be good to keep this enum closer to elf-related code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D130506/new/

https://reviews.llvm.org/D130506