[PATCH] D131960: [IR] Reimplement time tracing of NewPassManager by PassInstrumentation framework

Jamie Schmeiser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Sep 6 05:27:52 PDT 2022


jamieschmeiser added inline comments.


================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1168
+    PassInstrumentationCallbacks &PIC) {
+  if (getTimeTraceProfilerInstance() == nullptr)
+    return;
----------------



================
Comment at: llvm/lib/Passes/StandardInstrumentations.cpp:1170
+    return;
+  this->PIC = &PIC;
+  PIC.registerBeforeNonSkippedPassCallback(
----------------
This is unnecessary (see comment in header)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D131960/new/

https://reviews.llvm.org/D131960



More information about the llvm-commits mailing list