[PATCH] D131960: [IR] Reimplement time tracing of NewPassManager by PassInstrumentation framework
Jamie Schmeiser via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Sep 6 05:17:19 PDT 2022
jamieschmeiser requested changes to this revision.
jamieschmeiser added inline comments.
This revision now requires changes to proceed.
================
Comment at: llvm/include/llvm/Passes/StandardInstrumentations.h:422
+private:
+ PassInstrumentationCallbacks *PIC;
+ // Implementation of pass instrumentation callbacks.
----------------
Why are you saving PIC as a member? You do not refer to it other than initializing it. Please remove it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D131960/new/
https://reviews.llvm.org/D131960
More information about the llvm-commits
mailing list