[PATCH] D133282: [TargetLowering][X86][AMDGPU] Teach expandMUL_LOHI to handle a mix of sign and zero extend.

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Sep 5 12:49:32 PDT 2022


spatel added a comment.

In D133282#3770953 <https://reviews.llvm.org/D133282#3770953>, @craig.topper wrote:

> Would we do a second combine for (add Z, (and X, (neg Y)) to get the (sub Z, (and X, Y))?

I didn't look past the first missing transform...but sure, if that's missing too. :)

Something like this?
https://alive2.llvm.org/ce/z/zFxp6A

Seems to be missed in IR too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133282/new/

https://reviews.llvm.org/D133282



More information about the llvm-commits mailing list