[PATCH] D133198: [SCCP] convert signed div/rem to unsigned for non-negative operands

[Baoshan Pang via Phabricator via llvm-commits]

BaoshanPang added inline comments.


================
Comment at: llvm/test/Transforms/SCCP/divrem.ll:141
 
+; negative test
+
----------------
spatel wrote:
> BaoshanPang wrote:
> > Should we add a 'TODO' here just like what we do for @sdiv_nonneg0_nonnegconst1 ?
> This one is not safe to transform - it needs 'nsw':
> https://alive2.llvm.org/ce/z/VDuSrw
> 
> I can make that explicit in the comment.
I see. Thanks for the example.
Then the patch looks good to me.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D133198/new/

https://reviews.llvm.org/D133198